Bump minitest and clean up as minitest 6 is now widely supported#2578
Merged
paracycle merged 1 commit intoShopify:mainfrom Apr 6, 2026
Merged
Bump minitest and clean up as minitest 6 is now widely supported#2578paracycle merged 1 commit intoShopify:mainfrom
paracycle merged 1 commit intoShopify:mainfrom
Conversation
larouxn
changed the title
larouxn
changed the title
KaanOzkan
approved these changes
Apr 6, 2026
Contributor
|
I'm not sure about:
I'll leave it up to @paracycle |
Member
I made those changes because they weren't working properly anyway, so no need to revert any of those. |
paracycle
approved these changes
Apr 6, 2026
Contributor
Author
|
I think a few of the CI steps may have failed on main post merge (CI failure logs) due to my other PR that added checksums to the Gemfile.lock being merged first time then me not rebasing this PR pre-merge. I'll open a quick follow up fix PR in a little bit. Should just be a quick Gemfile.lock update/sync. EDIT: follow up PR is up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Proposing we clean up some of the complications and changes we added to our spec helper in order to conditionally use Minitest 6 as until recently Rails 8.1 supported it Minitest 6 but Rails 8.0 did not. This is all possible now that Rails 8.0.5 and minitest-reporters 1.8.0 are out.
Note, there may be some changes that were made to
spec_reporter.rbthat we want to revert.Follow up to
Implementation
Mostly a semi-revert of the temporary changes made in the above two PRs.
Tests
CI should prove if everything is working well. Have run such myself over here and all looks good.
https://github.com/larouxn/tapioca/actions/runs/23947725345/job/69847547756 (regen-ed RBIs since this run)